Re: Aw: Re: [RFC] arm64: dts: use size of reserved partition for bl2

From: AngeloGioacchino Del Regno
Date: Mon Apr 03 2023 - 10:04:50 EST


Il 03/04/23 15:56, Frank Wunderlich ha scritto:
Gesendet: Montag, 03. April 2023 um 14:43 Uhr
Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>
Il 03/04/23 12:58, Frank Wunderlich ha scritto:
From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

To store uncompressed bl2 more space is required than partition is
actually defined.

Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

If this doesn't get changed anymore, I'm fine with it... but a question arises:
did you send patches to add your BPI-r3 board(s) to upstream u-boot?

currently i use the rfb dts for r3 in uboot: arch/arm/dts/mt7986a-sd-rfb.dts

this file in upstream uboot has no partitions defined

https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/mt7986a-sd-rfb.dts#L144

but i added them there too and i wrote content by offsets to main device (not to partitions).

https://github.com/frank-w/u-boot/blob/2023-04-bpi/arch/arm/dts/mt7986a-sd-rfb.dts#L154

so yes basicly it needs to be send there too, maybe as additional dts.


I strongly encourage you to send this change to u-boot as well as changing the
kernel devicetree... and when you do, you can add a reference to the list and/or
commit @ u-boot on the commit that you'll send here for the kernel... but there's
another question...

...what happens if you run the kernel on a device with an older partition layout?
Does anything break?
I don't think that anything does, since this is read-only anyway, but just to be
sure... :-)

Besides, you have to fix the commit description, but you knew that already.

P.S.: When you post a RFC, giving it the right commit title helps sometimes! :-P

Regards,
Angelo