Re: [PATCH v1 03/14] extcon: Use DECLARE_BITMAP() to declare bit arrays
From: Chanwoo Choi
Date: Mon Apr 03 2023 - 10:04:59 EST
On 23. 3. 22. 23:39, Andy Shevchenko wrote:
> Bit arrays has a specific type helper for the declaration.
> Use it instead of homegronw equivalent.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/extcon/extcon.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 79006ab5334b..70e9755ba2bc 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -230,10 +230,10 @@ struct extcon_cable {
> union extcon_property_value jack_propval[EXTCON_PROP_JACK_CNT];
> union extcon_property_value disp_propval[EXTCON_PROP_DISP_CNT];
>
> - unsigned long usb_bits[BITS_TO_LONGS(EXTCON_PROP_USB_CNT)];
> - unsigned long chg_bits[BITS_TO_LONGS(EXTCON_PROP_CHG_CNT)];
> - unsigned long jack_bits[BITS_TO_LONGS(EXTCON_PROP_JACK_CNT)];
> - unsigned long disp_bits[BITS_TO_LONGS(EXTCON_PROP_DISP_CNT)];
> + DECLARE_BITMAP(usb_bits, EXTCON_PROP_USB_CNT);
> + DECLARE_BITMAP(chg_bits, EXTCON_PROP_CHG_CNT);
> + DECLARE_BITMAP(jack_bits, EXTCON_PROP_JACK_CNT);
> + DECLARE_BITMAP(disp_bits, EXTCON_PROP_DISP_CNT);
> };
>
> static struct class *extcon_class;
Applied it.
--
Best Regards,
Samsung Electronics
Chanwoo Choi