Re: [PATCH] arm64: dts: rockchip: Change serial baud rate for Pinephone Pro to 1.5 MB
From: Peter Robinson
Date: Tue Apr 04 2023 - 04:18:49 EST
On Tue, Apr 4, 2023 at 9:13 AM Jarrah <kernel@undef.tools> wrote:
>
> Hi,
>
> On 4/4/23 17:51, Heiko Stübner wrote:
> > The interesting question is always if this will break someone else's setup.
> > I've never really understood the strange setting of 1.5MBps, but on the
> > other hand it _is_ a reality on most boards.
> >
> > Personally I don't care that much either way, but would like a comment
> > from the other people working on that device - if possible.
>
>
> I don't have a strong opinion either way, but I would note that
> Tow-Boot[0] which later models of this device ship with uses 115200,
> meaning that this would put the device out of sync with the default
> u-boot implementation from the factory.
Upstream U-Boot support uses the 1.5m that all the other rockchip devices use.
> At least for me it's been convenient to have both the PP and PPP use the
> same settings while debugging.
Pinebook Pro and numerous other devices use 1.5m so I don't think what
other devices use make are ultimately particularly relevant.