Re: [PATCH V2] dt-bindings: input: pwm-beeper: convert to dt schema

From: Krzysztof Kozlowski
Date: Tue Apr 04 2023 - 04:17:53 EST


On 04/04/2023 08:44, Peng Fan wrote:


>>
>>> +
>>> + beeper-hz:
>>> + description: bell frequency in Hz
>>> + minimum: 1
>>> + maximum: 4
>>
>> default is 1000, so how constraints can be lower than default? Also - missing
>> default.
> [Peng Fan]
> I am not sure what maximum value should be set. Previously I set 256, Rob
> questioned it.

Yep, because 256 is power of 2, so really does not look correct. It is
still lower than default, right?

Best regards,
Krzysztof