Re: [PATCH V2] dt-bindings: input: pwm-beeper: convert to dt schema

From: Rob Herring
Date: Tue Apr 04 2023 - 09:51:35 EST


On Tue, Apr 04, 2023 at 10:17:45AM +0200, Krzysztof Kozlowski wrote:
> On 04/04/2023 08:44, Peng Fan wrote:
>
>
> >>
> >>> +
> >>> + beeper-hz:
> >>> + description: bell frequency in Hz
> >>> + minimum: 1
> >>> + maximum: 4
> >>
> >> default is 1000, so how constraints can be lower than default? Also - missing
> >> default.
> > [Peng Fan]
> > I am not sure what maximum value should be set. Previously I set 256, Rob
> > questioned it.
>
> Yep, because 256 is power of 2, so really does not look correct. It is
> still lower than default, right?

It's Hertz and an audible (to humans) range! At most that's 60 -
10000Hz. I imagine any beeper h/w is capable of much narrower range than
that, but don't know what's typical.

Rob