Re: [PATCH] video/aperture: fix typos

From: Javier Martinez Canillas
Date: Tue Apr 04 2023 - 07:09:13 EST


Javier Martinez Canillas <javierm@xxxxxxxxxx> writes:

[...]

>>> /*
>>> * Remove the device from the device hierarchy. This is the right thing
>>> - * to do for firmware-based DRM drivers, such as EFI, VESA or VGA. After
>>> + * to do for firmware-based fb drivers, such as EFI, VESA or VGA. After
>>
>> That sentences is not well phrased. Maybe say 'This is required for
>> firmware-provided graphics, such as EFI, VESA or VGA.'
>>
>
> Graphic drivers or display drivers would indeed be more accurate here. But
> I think that "fb drivers" is still well pharsed since the are other places
> where either fbdev or DRM drivers for firmware-provided framebuffers are
> named like that.
>

Sui,

Maybe you could post a follow-up patch to improve the comment as suggested
by Thomas?

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat