Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy

[Martin Blumenstingl]

On Wed, Apr 5, 2023 at 11:40 AM Michael Sit Wei Hong
<michael.wei.hong.sit@xxxxxxxxx> wrote:
>
> Some DT devices already have phy device configured in the DT/ACPI.
> Current implementation scans for a phy unconditionally even though
> there is a phy listed in the DT/ACPI and already attached.
>
> We should check the fwnode if there is any phy device listed in
> fwnode and decide whether to scan for a phy to attach to.y
>
> Reported-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@xxxxxxxxx>
This also works great on my X96 Air (and I presume it will fix all
other Amlogic boards):
Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>


Thanks a lot for being so quick with this fix!