Re: [PATCH net 1/1] net: stmmac: check fwnode for phy device before scanning for phy

From: Guenter Roeck
Date: Wed Apr 05 2023 - 15:02:30 EST


On Wed, Apr 05, 2023 at 05:39:45PM +0800, Michael Sit Wei Hong wrote:
> Some DT devices already have phy device configured in the DT/ACPI.
> Current implementation scans for a phy unconditionally even though
> there is a phy listed in the DT/ACPI and already attached.
>
> We should check the fwnode if there is any phy device listed in
> fwnode and decide whether to scan for a phy to attach to.y
>
> Reported-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Fixes: fe2cfbc96803 ("net: stmmac: check if MAC needs to attach to a PHY")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@xxxxxxxxx>
> Tested-by: Shahab Vahedi <shahab@xxxxxxxxxxxx>
> Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Tested-by: Marek Szyprowski

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter