Re: [PATCH 2/8] scripts/mksysmap: remove comments described in nm(1)
From: Masahiro Yamada
Date: Mon Apr 10 2023 - 05:38:47 EST
On Sat, Apr 8, 2023 at 3:46 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
>
> On Wed, Mar 8, 2023 at 3:52 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > I do not think we need to repeat what is written in 'man nm'.
>
> I agree, but the paragraphs following the one you removed refer to a,
> U, N, w, T, t, and W now with no context that those are the nm
> formats.
>
> I'm ok with this patch, but please consider adding a sentence along
> the lines of:
>
> The following refers to the symbol type as per nm(1).
OK, I will fold this comment locally.
Thanks.
--
Best Regards
Masahiro Yamada