Re: [PATCH 3/8] scripts/mksysmap: use sed with in-line comments
From: Masahiro Yamada
Date: Mon Apr 10 2023 - 05:39:08 EST
On Sat, Apr 8, 2023 at 11:29 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Sat, Apr 8, 2023 at 4:00 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
> >
> > On Wed, Mar 8, 2023 at 3:53 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > >
> > > Move comments close to the code.
> >
> > Consider adding to the commit message why you switch from grep to sed;
> > that's currently unclear.
>
>
>
> I just thought "Move comments close to the code"
> explained my motivation.,
>
>
> I want to insert in-line comments.
> Something like the following.
> Apparently, it does not work.
>
>
> $NM -n $1 | grep -v \
> # comment1
> -e ' [aNUw] ' \
> # comment2
> -e ' \$' \
> # comment3
> -e ' \.L' \
> # comment4
> -e ' __crc_' \
> # comment5
> -e ' __kstrtab_' \
> # comment6
> -e ' __kstrtabns_' \
> # comment7
> -e ' L0$' \
> > $2
>
>
>
Anyway, I will rephase the commit description.
"""
It is not feasible to insert comments in a multi-line shell command.
Use sed, and move comments close to the code.
"""
--
Best Regards
Masahiro Yamada