Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules

From: Javier Martinez Canillas
Date: Mon Apr 10 2023 - 13:52:49 EST


Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> writes:

> On 10/04/2023 14:49, Javier Martinez Canillas wrote:
>> Enable zram and dependencies as loadable modules. This allows to use the
>> /dev/zramX virtual block devices as swap stored in system memory.
>>
>> Options were taken from commit 5c824e8be64d ("ARM: omap2plus_defconfig:
>> Enable zram as loadable modules") that does the same for OMAP2+ platforms.
>
> Neither this commit msg nor above omap commit explain why do we want it.
> I know what zram is, I know its purpose, but the commit should answer
> why we want it in defconfig.
>
> To me it is not a matching defconfig at all:
> 1. Not a feature related to Exynos hardware,
> 2. Not needed for basic boot (systemd) or debug.
>

It's needed for basic boot on distros that use swap on zram (i.e: Fedora).

I just had this as a local change to boot an ODROID XU4. But have a custom
defconfig for other boards anyways, so I'll just do the same for this one.

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat