Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules
From: Krzysztof Kozlowski
Date: Mon Apr 10 2023 - 14:06:12 EST
On 10/04/2023 19:51, Javier Martinez Canillas wrote:
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> writes:
>
>> On 10/04/2023 14:49, Javier Martinez Canillas wrote:
>>> Enable zram and dependencies as loadable modules. This allows to use the
>>> /dev/zramX virtual block devices as swap stored in system memory.
>>>
>>> Options were taken from commit 5c824e8be64d ("ARM: omap2plus_defconfig:
>>> Enable zram as loadable modules") that does the same for OMAP2+ platforms.
>>
>> Neither this commit msg nor above omap commit explain why do we want it.
>> I know what zram is, I know its purpose, but the commit should answer
>> why we want it in defconfig.
>>
>> To me it is not a matching defconfig at all:
>> 1. Not a feature related to Exynos hardware,
>> 2. Not needed for basic boot (systemd) or debug.
>>
>
> It's needed for basic boot on distros that use swap on zram (i.e: Fedora).
ZSWAP could be for this as well, but none of them should be used to be
able to boot Fedora. If Fedora requires them, it's something broken
there. I can setup SWAP on my eMMC as well, so why would I need ZRAM?
Best regards,
Krzysztof