Re: Possible incorrect handling of fault injection inside KMSAN instrumentation

[Alexander Potapenko]

On Wed, Apr 12, 2023 at 8:24 PM Dipanjan Das
<mail.dipanjan.das@xxxxxxxxx> wrote:
>
> On Wed, Apr 12, 2023 at 7:39 AM Alexander Potapenko <glider@xxxxxxxxxx> wrote:
>
> > Here are two patches that fix the problem:
> >  - https://github.com/google/kmsan/commit/b793a6d5a1c1258326b0f53d6e3ac8aa3eeb3499
> > - for kmsan_vmap_pages_range_noflush();
> >  - https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f24060cff
> > - for kmsan_ioremap_page_range()
> >
> > Can you please try them out?
>
> The second patch needs a small modification.
>
> The return value of `__vmap_pages_range_noflush` at Line 181
> (https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f24060cff#diff-6c23520766ef70571c16b74ed93474716645c7ba81dc07028c076b6fd5ad2731R181)
> should also be assigned to `mapped`. With this modification, the patch
> works.

Good catch, thanks!
I'll send an updated version.