RE: [EXT] Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI system atchdog driver

[Bharat Bhushan]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, April 14, 2023 4:52 PM
> To: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>; wim@xxxxxxxxxxxxxxxxxx;
> linux@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> linux-watchdog@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI
> system atchdog driver
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 14/04/2023 12:23, Bharat Bhushan wrote:
> > Add binding documentation for the Marvell octeonTX2 GTI system
> > watchdog driver.
> 
> Subject: typo: atchdog

Will fix, thanks

> 
> >
> > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> > ---
> >  .../watchdog/marvell-octeontx2-wdt.yaml       | 49 +++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yam
> > l
> > b/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yam
> > l
> > new file mode 100644
> > index 000000000000..e509f26c61b9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt
> > +++ .yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_sc
> > +hemas_watchdog_marvell-2Docteontx2-2Dwdt.yaml-
> 23&d=DwICaQ&c=nKjWec2b6
> >
> +R0mOyPaz7xtfQ&r=PAAlWswPe7d8gHlGbCLmy2YezyK7O3Hv_t2heGnouBw&m
> =wkYAMhB
> > +eHDmObOkMU_NKOHC7amkjDT6HfYf4lFfIUDZg4Oon51wGGw5jD-
> WmvjGD&s=YiPlJAjSU
> > +9eDReE-1_nRYFsMDoi4cKjvJDRy6jS1S4w&e=
> > +$schema:
> > +https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_me
> > +ta-2Dschemas_core.yaml-
> 23&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=PAAlWsw
> >
> +Pe7d8gHlGbCLmy2YezyK7O3Hv_t2heGnouBw&m=wkYAMhBeHDmObOkMU_N
> KOHC7amkjDT
> > +6HfYf4lFfIUDZg4Oon51wGGw5jD-
> WmvjGD&s=cMu8mewA0U1pRNMAp3MO6pf1fx9cLqXY
> > +n4botCarvzU&e=
> > +
> > +title: Marvell OcteonTX2 GTI system watchdog
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +maintainers:
> > +  - Bharat Bhushan <bbhushan2@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: marvell-octeontx2-wdt
> 
> That's not correct compatible. marvell is a vendor prefix.
> 
> Did you test the bindings before sending?

Will convert this to marvell,octeontx2-wdt

> 
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description:
> > +      OcteonTX2 GTI system watchdog register space
> 
> Drop description, it is obvious.

Ok,

> 
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +    description:
> > +      OcteonTX2 GTI system watchdog interrupt number
> 
> Ditto
> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +
> > +additionalProperties: false
> 
> unevaluatedProperties: false instead

Will remove

> 
> > +
> > +examples:
> > +  - |
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        watchdog@802000040000 {
> > +          compatible = "marvell-octeontx2-wdt";
> > +          reg = <0x8020 0x40000 0x0 0x20000>;
> 
> Are you sure that this is correct DTS? 32-bit numbers are usually 8-digit long. Plus
> size of 0x20000 is crazy huge. And the unit address is a bit unusual. Are you sure
> dtc W=1 does not say about any errors in your DTS?

Each cell is 32bit, so if we specify less than upper values becomes zeros (0s). 

> 
> 
> > +          interrupts = <0 38 1>;
> 
> Use defines for common flags.

Ok,

Thanks for review

-Bharat

> 
> > +        };
> > +    };
> > +
> > +...
> 
> Best regards,
> Krzysztof