Re: [PATCH v4 4/4] counter: 104-quad-8: Migrate to the regmap API
From: Andy Shevchenko
Date: Tue Apr 18 2023 - 03:45:17 EST
On Mon, Apr 17, 2023 at 03:50:50PM -0400, William Breathitt Gray wrote:
> The regmap API supports IO port accessors so we can take advantage of
> regmap abstractions rather than handling access to the device registers
> directly in the driver. With regmap we get boundary checks, read-write
> permissions, operation synchronization locks, and more for free. Most
> important of all, rather than rolling our own we utilize implementations
> that are known to work and gain from any future improvements and fixes
> that come.
...
> - Use "int ret" for regmap_* return values throughout for consistency
Looking into it I would think it might be better to have a precursor patch.
But it's up to you. It looks good now.
--
With Best Regards,
Andy Shevchenko