Re: [PATCH v4 4/4] counter: 104-quad-8: Migrate to the regmap API

[William Breathitt Gray]

On Tue, Apr 18, 2023 at 10:44:57AM +0300, Andy Shevchenko wrote:
> On Mon, Apr 17, 2023 at 03:50:50PM -0400, William Breathitt Gray wrote:
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver. With regmap we get boundary checks, read-write
> > permissions, operation synchronization locks, and more for free. Most
> > important of all, rather than rolling our own we utilize implementations
> > that are known to work and gain from any future improvements and fixes
> > that come.
> 
> ...
> 
> >  - Use "int ret" for regmap_* return values throughout for consistency
> 
> Looking into it I would think it might be better to have a precursor patch.
> But it's up to you. It looks good now.
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Yes, there are a few unrelated changes in this patch just to adjust from
the "err" to "ret" symbol. It's relatively minor, so if I send a v5 of
this series, I'll separate those changes to their own precursor patch to
reduce the noise here. Regardless, would you like me to add a
Reviewed-by tag for you for the changes in this patch?

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature