Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

[Harshit Mogalapalli]

Hi all,

On 18/04/23 9:30 pm, Shuah Khan wrote:
> On 4/18/23 09:45, Naresh Kamboju wrote:
> > On Tue, 18 Apr 2023 at 21:04, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
> > > > On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> > > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > > > This is the start of the stable review cycle for the 5.10.178 release.
> > > > > There are 124 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, 
> > > > > please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > >          
> > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > > > > or in the git tree and branch at:
> > > > >          
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > Following build errors noticed on 5.15 and 5.10.,
> > > >
> > > >
> > > > > Waiman Long <longman@xxxxxxxxxx>
> > > > >      cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
> > >
> > > That's a documentation patch, it can not:
> >
> > Sorry for my mistake in trimming the email at the wrong place.
> >
> > I have pasted down of the email as this suspected patch,
> >
> > cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> > commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
> >
> >
> > > > kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> > > > kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> > > > (first use in this function); did you mean 'cgroup_put'?
> > > >   2941 |         lockdep_assert_held(&cgroup_mutex);
> > >
> > > Cause this.
> > >
> > > What arch is failing here?  This builds for x86.
> >
> > Not for me.
>
> It is failing for me on x86_64 with CONFIG_CGROUPS=y
> and CONFIG_CGROUP_CPUACCT=y

Added some observations on 5.15.y thread:

https://lore.kernel.org/all/bd46521c-a167-2872-fecb-2b0f32855a24@xxxxxxxxxx/

Thanks,
Harshit

> kernel/cgroup/cpuset.c: In function ‘cpuset_can_fork’:
> kernel/cgroup/cpuset.c:2941:30: error: ‘cgroup_mutex’ undeclared (first 
> use in this function); did you mean ‘cgroup_put’?
>   2941 |         lockdep_assert_held(&cgroup_mutex);
>        |                              ^~~~~~~~~~~~
> ./include/linux/lockdep.h:393:61: note: in definition of macro 
> ‘lockdep_assert_held’
>    393 | #define lockdep_assert_held(l)                  do { (void)(l); 
> } while (0)
>        |                                                             ^
> kernel/cgroup/cpuset.c:2941:30: note: each undeclared identifier is 
> reported only once for each function it appears in
>   2941 |         lockdep_assert_held(&cgroup_mutex);
>        |                              ^~~~~~~~~~~~
> ./include/linux/lockdep.h:393:61: note: in definition of macro 
> ‘lockdep_assert_held’
>    393 | #define lockdep_assert_held(l)                  do { (void)(l); 
> } while (0)
>
> thanks,
> -- Shuah