Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

[Guenter Roeck]

On 4/18/23 08:34, Greg Kroah-Hartman wrote:
> On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
> > On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > This is the start of the stable review cycle for the 5.10.178 release.
> > > There are 124 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Following build errors noticed on 5.15 and 5.10.,
> >
> >
> > > Waiman Long <longman@xxxxxxxxxx>
> > >      cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
>
> That's a documentation patch, it can not:
>
> > kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> > kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> > (first use in this function); did you mean 'cgroup_put'?
> >   2941 |         lockdep_assert_held(&cgroup_mutex);
>
> Cause this.
>
> What arch is failing here?  This builds for x86.
No, it doesn't.

Build reference: v5.10.177-125-g19b9d9b9f62e
Compiler version: x86_64-linux-gcc (GCC) 11.3.0
Assembler version: GNU assembler (GNU Binutils) 2.39

Building x86_64:defconfig ... failed
--------------
Error log:
In file included from include/linux/rcupdate.h:29,
                 from include/linux/rculist.h:11,
                 from include/linux/pid.h:5,
                 from include/linux/sched.h:14,
                 from include/linux/ratelimit.h:6,
                 from include/linux/dev_printk.h:16,
                 from include/linux/device.h:15,
                 from include/linux/node.h:18,
                 from include/linux/cpu.h:17,
                 from kernel/cgroup/cpuset.c:25:
kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared (first use in this function); did you mean 'cgroup_put'?
 2941 |         lockdep_assert_held(&cgroup_mutex);
      |                              ^~~~~~~~~~~~
include/linux/lockdep.h:393:61: note: in definition of macro 'lockdep_assert_held'
  393 | #define lockdep_assert_held(l)                  do { (void)(l); } while (0)
      |                                                             ^
kernel/cgroup/cpuset.c:2941:30: note: each undeclared identifier is reported only once for each function it appears in
 2941 |         lockdep_assert_held(&cgroup_mutex);
      |                              ^~~~~~~~~~~~
include/linux/lockdep.h:393:61: note: in definition of macro 'lockdep_assert_held'
  393 | #define lockdep_assert_held(l)                  do { (void)(l); } while (0)
      |                                                             ^
make[3]: *** [scripts/Makefile.build:286: kernel/cgroup/cpuset.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:503: kernel/cgroup] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1828: kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:192: __sub-make] Error 2