Re: [PATCH REPOST blktests v2 4/9] nvme: Use runtime fio background jobs

[Daniel Wagner]

On Fri, Apr 21, 2023 at 08:29:22AM +0200, Hannes Reinecke wrote:
 > --- a/tests/nvme/040
> > +++ b/tests/nvme/040
> > @@ -38,7 +38,8 @@ test() {
> >   	# start fio job
> >   	echo "starting background fio"
> >   	_run_fio_rand_io --filename="/dev/${nvmedev}n1" --size=1g \
> > -		--group_reporting --ramp_time=5  &> /dev/null &
> > +		--group_reporting --ramp_time=5 \
> > +		--time_based --runtime=1m &> /dev/null &
> >   	sleep 5
> >   	# do reset/remove operation
> 
> Wouldn't it be better to let _run_fio_rand_io pick the correct size?

Yes, makes sense.