Re: [PATCH v2 22/24] selftests/resctrl: Split measure_cache_vals() function

[Reinette Chatre]

Hi Ilpo,

On 4/18/2023 4:45 AM, Ilpo Järvinen wrote:
> The measure_cache_vals() function does a different thing depending on
> the test case that called it:
>   - For CAT, it measures LLC perf misses 2.

What does the "2" represent?

>   - For CMT, it measures LLC occupancy through resctrl.
> 
> Split these two functionalities such that CMT test calls a new function
> called measure_llc_resctrl() to get LLC occupancy through resctrl and
> CAT test directly calls get_llc_perf().
> 

The changelog mentions 'split' but the split does not end up the same for
the two usages. Why does this split end up with one usage moving to a direct
call (get_llc_perf()) while the other usage remains with a wrapper?
Why not open code both?


Reinette