Re: [PATCH v2 23/24] selftests/resctrl: Split show_cache_info() to test specific and generic parts

From: Reinette Chatre
Date: Fri Apr 21 2023 - 20:22:49 EST


Hi Ilpo,

On 4/18/2023 4:45 AM, Ilpo Järvinen wrote:
> show_cache_info() attempts to do calculate the results and provide
> generic cache information. It makes hard to alter the pass/fail
> conditions.

I find the above hard to read. How about:

show_cache_info() calculates results and provide
generic cache information. This makes it hard to alter
pass/fail conditions.


>
> Separate the the test specific checks into CAT and CMT test files and

"the the" -> "the"

> leave only the generic information part into show_cache_info().
>

Reinette