Re: [PATCH v2 9/9] ASoC: simple-card: Handle additional devices

From: Kuninori Morimoto
Date: Wed May 24 2023 - 20:01:39 EST

Hi Herve

Thank you for your reply.

> So, IMHO, calling simple_populate_aux() from __simple_for_each_link() is
> not correct as it has nothing to do with DAI links and must be call once
> per Card.

My biggest concern is that this code is calling same code multiple times.
It is easy to forget such thing when updating in this kind of code.
We don't forget / take mistake if these are merged.
But we have such code everywhere ;) this is just my concern, not a big deal.

static int __simple_for_each_link (...)
=> add_devs = of_get_child_by_name(top, PREFIX "additional-devs");

static int simple_populate_aux(...)
=> node = of_get_child_by_name(dev->of_node, PREFIX "additional-devs");

Thank you for your help !!

Best regards
Kuninori Morimoto