Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver

[Lee Jones]

On Mon, 01 May 2023, Linus Walleij wrote:

> The TWL4030 GPIO driver has a custom platform data .set_up()
> callback to call back into the platform and do misc stuff such
> as hog and export a GPIO for WLAN PWR on a specific OMAP3 board.
> 
> Avoid all the kludgery in the platform data and the boardfile
> and just put the quirks right into the driver. Make it
> conditional on OMAP3.
> 
> I think the exported GPIO is used by some kind of userspace
> so ordinary DTS hogs will probably not work.
> 
> Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base")
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  arch/arm/mach-omap2/omap_device.c  |  1 -
>  arch/arm/mach-omap2/pdata-quirks.c | 41 +-----------------------------
>  drivers/gpio/gpio-twl4030.c        | 52 ++++++++++++++++++++++++++------------

>  include/linux/mfd/twl.h            |  3 ---

Acked-by: Lee Jones <lee@xxxxxxxxxx>

>  4 files changed, 37 insertions(+), 60 deletions(-)

-- 
Lee Jones [李琼斯]