Re: [PATCH net-next 08/11] iavf: switch to Page Pool

From: Alexander Lobakin
Date: Thu May 25 2023 - 07:08:41 EST


From: David Christensen <drc@xxxxxxxxxxxxxxxxxx>
Date: Tue, 23 May 2023 15:42:28 -0700

>
>
> On 5/16/23 9:18 AM, Alexander Lobakin wrote:
>> Now that the IAVF driver simply uses dev_alloc_page() + free_page() with
>> no custom recycling logics and one whole page per frame, it can easily
>> be switched to using Page Pool API instead.
>
> Any plans to add page pool fragmentation support (i.e.
> PP_FLAG_PAGE_FRAG) in the future to better support architectures with
> larger page sizes such as 64KB on ppc64le?

Currently no, we resigned from page fragmentation due to the complexity
and restrictions it provides for no benefits on x86_64. But I remember
that pages > 4 Kb exist (I have a couple MIPS boards where I have fun
sometimes and page size is set to 16 Kb there. But still always use 1
page per frame).
By "better support" you mean reducing memory usage or something else?

>
> Dave

Thanks,
Olek