Re: [PATCH] Remove hardcoded static string length

From: Kenny Ho
Date: Thu May 25 2023 - 11:38:10 EST


On Thu, May 25, 2023 at 11:04 AM David Laight <David.Laight@xxxxxxxxxx> wrote:
> But isn't UTS_RELEASE usually much shorter?
> I think it is what 'uname -r' prints, the longest I've seen recently
> is "3.10.0-1127.19.1.el7.x86_64" - well under the limit.

Usually yes, but I believe LOCALVERSION can be appended to
KERNELRELEASE / UTS_RELEASE which can makes it much longer.

> > "The standard formulation seems to be: <project> <version> built
> > <yyyy>-<mm>-<dd>"
>
> Which I don't recall the string actually matching?
> Also the people who like reproducible builds don't like __DATE__.

That's correct, it was not matching even when it was introduced. I am
simply taking that as people caring about the content and not simply
making rxrpc_version_string == UTS_RELEASE. The current format is:

"linux-" UTS_RELEASE " AF_RXRPC"

Kenny