Re: wifi: rtw89: use flexible array member in rtw89_btc_btf_tlv
From: Kalle Valo
Date: Thu May 25 2023 - 12:14:41 EST
Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> struct rtw89_btc_btf_tlv contains a one-byte member that is intended as a
> flexible array:
>
> In function 'fortify_memcpy_chk',
> inlined from '_append_tdma' at drivers/net/wireless/realtek/rtw89/coex.c:1579:3:
> include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
> 583 | __write_overflow_field(p_size_field, size);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Make this actually use a flexible array to let the compiler understand.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
Patch applied to wireless-next.git, thanks.
47e612268ea0 wifi: rtw89: use flexible array member in rtw89_btc_btf_tlv
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230523113241.2772811-1-arnd@xxxxxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches