Re: [PATCH net-next v3 5/6] net: phy: microchip_t1s: remove unnecessary interrupts disabling code

From: Ramón Nordin Rodriguez
Date: Thu May 25 2023 - 14:30:37 EST


On Wed, May 24, 2023 at 08:15:38PM +0530, Parthiban Veerasooran wrote:
> By default, except Reset Complete interrupt in the Interrupt Mask 2
> Register all other interrupts are disabled/masked. As Reset Complete
> status is already handled, it doesn't make sense to disable it.
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@xxxxxxxxxxxxx>
> ---

Reviewed-by: Ramón Nordin Rodriguez <ramon.nordin.rodriguez@xxxxxxxxxxx>
Tested-by: Ramón Nordin Rodriguez <ramon.nordin.rodriguez@xxxxxxxxxxx>

Testing has been pretty rudamentary, but the procedure has been as
follows:
* Hotplug 2 devices
* Unload and reload the lkm
* Ping 2 devices over ipv6 link local addresses
All testing has been performed with the EVB-LAN8670-USB