Re: [PATCH v6 16/20] modpost: merge fromsec=DATA_SECTIONS entries in sectioncheck table

From: Nick Desaulniers
Date: Thu May 25 2023 - 14:31:06 EST


On Sun, May 21, 2023 at 9:05 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> You can merge these entries.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

> ---
>
> scripts/mod/modpost.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 516323c3910a..aea9d6cd243d 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -884,12 +884,7 @@ static const struct sectioncheck sectioncheck[] = {
> },
> {
> .fromsec = { DATA_SECTIONS, NULL },
> - .bad_tosec = { ALL_XXXINIT_SECTIONS, NULL },
> - .mismatch = DATA_TO_ANY_INIT,
> -},
> -{
> - .fromsec = { DATA_SECTIONS, NULL },
> - .bad_tosec = { INIT_SECTIONS, NULL },
> + .bad_tosec = { ALL_XXXINIT_SECTIONS, INIT_SECTIONS, NULL },
> .mismatch = DATA_TO_ANY_INIT,
> },
> {
> --
> 2.39.2
>


--
Thanks,
~Nick Desaulniers