arch/riscv/include/asm/atomic.h:339 arch_atomic64_dec_if_positive() warn: inconsistent indenting
From: kernel test robot
Date: Sun May 28 2023 - 04:24:21 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 416839029e3858f61dc7dd346559c03e74ed8380
commit: 1d7f6932c522ea95668e14265175ce3d753d0c24 riscv: atomic: Optimize dec_if_positive functions
date: 1 year ago
config: riscv-randconfig-m031-20230526 (https://download.01.org/0day-ci/archive/20230528/202305281649.3367YTx7-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305281649.3367YTx7-lkp@xxxxxxxxx/
smatch warnings:
arch/riscv/include/asm/atomic.h:339 arch_atomic64_dec_if_positive() warn: inconsistent indenting
vim +339 arch/riscv/include/asm/atomic.h
fab957c11efe2f Palmer Dabbelt 2017-07-10 332
fab957c11efe2f Palmer Dabbelt 2017-07-10 333 #ifndef CONFIG_GENERIC_ATOMIC64
1d7f6932c522ea Guo Ren 2022-05-05 334 static __always_inline s64 arch_atomic64_dec_if_positive(atomic64_t *v)
fab957c11efe2f Palmer Dabbelt 2017-07-10 335 {
0754211847d7a2 Mark Rutland 2019-05-22 336 s64 prev;
0754211847d7a2 Mark Rutland 2019-05-22 337 long rc;
fab957c11efe2f Palmer Dabbelt 2017-07-10 338
fab957c11efe2f Palmer Dabbelt 2017-07-10 @339 __asm__ __volatile__ (
5ce6c1f3535fa8 Andrea Parri 2018-03-09 340 "0: lr.d %[p], %[c]\n"
1d7f6932c522ea Guo Ren 2022-05-05 341 " addi %[rc], %[p], -1\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 342 " bltz %[rc], 1f\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 343 " sc.d.rl %[rc], %[rc], %[c]\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 344 " bnez %[rc], 0b\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 345 " fence rw, rw\n"
5ce6c1f3535fa8 Andrea Parri 2018-03-09 346 "1:\n"
fab957c11efe2f Palmer Dabbelt 2017-07-10 347 : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter)
1d7f6932c522ea Guo Ren 2022-05-05 348 :
fab957c11efe2f Palmer Dabbelt 2017-07-10 349 : "memory");
1d7f6932c522ea Guo Ren 2022-05-05 350 return prev - 1;
fab957c11efe2f Palmer Dabbelt 2017-07-10 351 }
fab957c11efe2f Palmer Dabbelt 2017-07-10 352
:::::: The code at line 339 was first introduced by commit
:::::: fab957c11efe2f405e08b9f0d080524bc2631428 RISC-V: Atomic and Locking Code
:::::: TO: Palmer Dabbelt <palmer@xxxxxxxxxxx>
:::::: CC: Palmer Dabbelt <palmer@xxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki