Re: [PATCH v4 6/9] dt-bindings: sc16is7xx: Add property to change GPIO function

[Hugo Villeneuve]

On Mon, 29 May 2023 19:19:27 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Mon, May 29, 2023 at 10:07:08AM -0400, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > 
> > Some variants in this series of UART controllers have GPIO pins that
> > are shared between GPIO and modem control lines.
> > 
> > The pin mux mode (GPIO or modem control lines) can be set for each
> > ports (channels) supported by the variant.
> > 
> > This adds a property to the device tree to set the GPIO pin mux to
> > modem control lines on selected ports if needed.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > ---
> >  .../bindings/serial/nxp,sc16is7xx.txt         | 46 +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > index 0fa8e3e43bf8..74dfbbf7b2cb 100644
> > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > @@ -23,6 +23,9 @@ Optional properties:
> >      1 = active low.
> >  - irda-mode-ports: An array that lists the indices of the port that
> >  		   should operate in IrDA mode.
> > +- nxp,modem-control-line-ports: An array that lists the indices of the port that
> > +				should have shared GPIO lines configured as
> > +				modem control lines.
> >  
> >  Example:
> >          sc16is750: sc16is750@51 {
> > @@ -35,6 +38,26 @@ Example:
> >                  #gpio-cells = <2>;
> >          };
> >  
> > +	sc16is752: sc16is752@54 {
> > +		compatible = "nxp,sc16is752";
> > +		reg = <0x54>;
> > +		clocks = <&clk20m>;
> > +		interrupt-parent = <&gpio3>;
> > +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> > +		nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */
> > +		gpio-controller; /* Port 0 as GPIOs */
> > +		#gpio-cells = <2>;
> > +	};
> > +
> > +	sc16is752: sc16is752@54 {
> > +		compatible = "nxp,sc16is752";
> > +		reg = <0x54>;
> 
> If this were not a txt binding, dt_binding_check would likely complain
> that you have two nodes with the same node address & 3 below.
> If you end up re-submitting, could you change that please?
> Otherwise,
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Hi Conor,
for the I2C section, I will use addresse 51, 52 and 54.

For the SPI section, I will use addresse 0, 1 and 2.

I will resubmit if there is a v5.

Thank you, Hugo.