Re: [PATCH v11 2/9] block: Add copy offload support infrastructure

From: Nitesh Shetty
Date: Tue May 30 2023 - 06:42:05 EST


On 23/05/29 06:55PM, Matthew Wilcox wrote:
On Mon, May 22, 2023 at 04:11:33PM +0530, Nitesh Shetty wrote:
+ token = alloc_page(gfp_mask);

Why is PAGE_SIZE the right size for 'token'? That seems quite unlikely.
I could understand it being SECTOR_SIZE or something that's dependent on
the device, but I cannot fathom it being dependent on the host' page size.

This has nothing to do with block device at this point, merely a place
holder to store information about copy offload such as src sectors, len.
Token will be typecasted by driver to get copy info.
SECTOR_SIZE also should work in this case, will update in next version.