RE: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error
From: Biju Das
Date: Tue May 30 2023 - 08:39:18 EST
Hi Laurent and Marc,
Thanks for your feedback.
> Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M
> {modprobe,bind} error
>
> On Mon, 29 May 2023 09:56:56 +0100,
> Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> >
> > The name is just informative so I suppose it's ok. It makes me wonder,
> > though, if the usb3drd driver shouldn't register the interrupt handler
> > itself.
>
> Well, it registers it itself, but pretending to be another device.
> Which is wrong on many levels.
OK, Will register the handler in usb3drd driver and expose register/unregister handler API
with cb function to avoid duplication of the code with renesas_usb3 driver.
Basically, there will be 2 exported functions + 1 spinlock introduced in usb3drd driver
USB3DRD driver register the IRQ handler
Probe/remove from renesas_usb3 driver register/unregister the cb function. Whenever there is drd irq
cb function will be called.
I will send next version with these changes.
Cheers,
Biju