Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error

From: Geert Uytterhoeven
Date: Tue May 30 2023 - 09:17:19 EST

Hi Biju,

On Tue, May 30, 2023 at 2:37 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M
> > {modprobe,bind} error
> >
> > On Mon, 29 May 2023 09:56:56 +0100,
> > Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > The name is just informative so I suppose it's ok. It makes me wonder,
> > > though, if the usb3drd driver shouldn't register the interrupt handler
> > > itself.
> >
> > Well, it registers it itself, but pretending to be another device.
> > Which is wrong on many levels.
> OK, Will register the handler in usb3drd driver and expose register/unregister handler API
> with cb function to avoid duplication of the code with renesas_usb3 driver.
> Basically, there will be 2 exported functions + 1 spinlock introduced in usb3drd driver
> USB3DRD driver register the IRQ handler
> Probe/remove from renesas_usb3 driver register/unregister the cb function. Whenever there is drd irq
> cb function will be called.

Please don't make it more complicated: if the parent device does not
use that interrupt, there is no need to move its handling to the parent
device driver.

Your patch looks fine to me, just replace the second ddata->dev, too.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds