Re: [PATCH v2 5/6] spi: cs42l43: Add SPI controller support

From: Charles Keepax
Date: Wed May 31 2023 - 04:46:33 EST


On Wed, May 31, 2023 at 05:26:46AM +0000, Mahapatra, Amit Kumar wrote:
> > + if (spi->chip_select == 0)
>
> New set/get APIs for accessing spi->chip_select were introduced by
> https://github.com/torvalds/linux/commit/303feb3cc06ac0665d0ee9c1414941200e60e8a3
> please use these APIs instead of accessing spi->chip_select directly.
>
> > + /* select another internal CS, which doesn't exist, so CS 0 is not used */
> > + if (spi->cs_gpiod)
>
> Same here for spi->cs_gpio
>

Thanks, I will get these fixed up for v3.

Thanks,
Charles