Re: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

[Marek Behún]

On Thu,  1 Jun 2023 17:17:04 -0700
msmulski2@xxxxxxxxx wrote:

>  				config->mac_capabilities |= MAC_5000FD |
>  					MAC_10000FD;
>  			}
> -			/* FIXME: USXGMII is not supported yet */
> -			/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */
> +			__set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
>  		}
>  	}

The set_bit() should go into the if statement above, since 6361 does not support usxgmii:

 /* 6361 only supports up to 2500BaseX */
 if (!is_6361) {
 	__set_bit(PHY_INTERFACE_MODE_5GBASER, supported);
 	__set_bit(PHY_INTERFACE_MODE_10GBASER, supported);
+	__set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
 	config->mac_capabilities |= MAC_5000FD |
 		MAC_10000FD;
 }
-/* FIXME: USXGMII is not supported yet */
-/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */




Marek