RE: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

[Michal Smulski]

Thank you for the review. I will make the change on the next version of this patch.
Michal

-----Original Message-----
From: Marek Behún <kabel@xxxxxxxxxx> 
Sent: Friday, June 2, 2023 12:54 AM
To: msmulski2@xxxxxxxxx
Cc: andrew@xxxxxxx; f.fainelli@xxxxxxxxx; olteanv@xxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; linux@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; simon.horman@xxxxxxxxxxxx; Michal Smulski <michal.smulski@xxxxxxxx>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

CAUTION: This email is originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


On Thu,  1 Jun 2023 17:17:04 -0700
msmulski2@xxxxxxxxx wrote:

>                               config->mac_capabilities |= MAC_5000FD |
>                                       MAC_10000FD;
>                       }
> -                     /* FIXME: USXGMII is not supported yet */
> -                     /* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */
> +                     __set_bit(PHY_INTERFACE_MODE_USXGMII, 
> + supported);
>               }
>       }

The set_bit() should go into the if statement above, since 6361 does not support usxgmii:

 /* 6361 only supports up to 2500BaseX */  if (!is_6361) {
        __set_bit(PHY_INTERFACE_MODE_5GBASER, supported);
        __set_bit(PHY_INTERFACE_MODE_10GBASER, supported);
+       __set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
        config->mac_capabilities |= MAC_5000FD |
                MAC_10000FD;
 }
-/* FIXME: USXGMII is not supported yet */
-/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */




Marek