Re: [PATCH] drm/meson: venc: include linux/bitfield.h

[Neil Armstrong]

On 02/06/2023 14:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Without this header, the use of FIELD_PREP() can cause a build failure:
>
> drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
> drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>
> Fixes: 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>   drivers/gpu/drm/meson/meson_venc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 2bdc2855e249b..3bf0d6e4fc30a 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -5,6 +5,7 @@
>    * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
>    */
>   
> +#include <linux/bitfield.h>
>   #include <linux/export.h>
>   #include <linux/iopoll.h>
>   

Acked-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>