Re: [PATCH] perf parse-events: Remove unneeded semicolon

[Namhyung Kim]

Hello,

On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@xxxxxxxxxx> wrote:
>
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
>
> Signed-off-by: Mingtong Bao <baomingtong001@xxxxxxxxxx>
> ---
>   tools/perf/util/parse-events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c
> b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
>       if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {

The format is broken, please fix your mail client not fix wrap long lines.
This time I fixed it manually, but you need to update your config.

Thanks,
Namhyung


>           assert(perf_pmus__supports_extended_type());
>           attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> -    };
> +    }
>
>       if (head_config) {
>           if (config_attr(&attr, head_config, parse_state->error,