Re: [PATCH] perf parse-events: Remove unneeded semicolon
From: Namhyung Kim
Date: Wed Jun 21 2023 - 13:24:35 EST
On Tue, Jun 20, 2023 at 3:50 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> Hello,
>
> On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@xxxxxxxxxx> wrote:
> >
> > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
> >
> > Signed-off-by: Mingtong Bao <baomingtong001@xxxxxxxxxx>
> > ---
> > tools/perf/util/parse-events.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-events.c
> > b/tools/perf/util/parse-events.c
> > index 629f7bd9fd59..42f84f61fabc 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> > parse_events_state *parse_state,
> > if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> > PERF_TYPE_HW_CACHE)) {
>
> The format is broken, please fix your mail client not fix wrap long lines.
> This time I fixed it manually, but you need to update your config.
Also there were other whitespace breakages, but applied to
perf-tools-next anyway, thanks!