Re: [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode

From: Andreas Kemnade
Date: Sat Jul 08 2023 - 09:03:40 EST


Hi,

On Thu, 6 Jul 2023 13:02:36 +0100
Mark Brown <broonie@xxxxxxxxxx> wrote:

> On Wed, Jul 05, 2023 at 09:56:11PM +0200, Andreas Kemnade wrote:
> > Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> > > It would be nicer to set the clock via the DT bindings, ideally with the
> > > clock bindings...
>
> > I found no path from these simple-audio-card things to provide a clk_id
> > to set_dai_sysclk. I would of course prefer such a thing. Do I have overlooked
> > something?
>
> Since we already have clock bindings we should use those to configure
> the clocks, there's several drivers that have added this support already
> - look for clock providers.

ok, looking around:
Just to make sure I am not running in a bad direction: Do you think
tlv320aic32x4{,-clk}.c is a good example? It is ignoring clk_id.
I was mentally bound to have to use clk_id there, so I did not found a good
solution.

So I guess I have to configure the chip as a master and using mclk and compare
register dumps with the state we have now and the state after the changes,
additionally to check bclk functionality directly.

Regards,
Andreas