Re: [PATCH 3/6] dt-bindings: thermal: tsens: Add ipq5332 compatible

From: Krzysztof Kozlowski
Date: Mon Jul 10 2023 - 16:06:46 EST


On 10/07/2023 12:37, Praveenkumar I wrote:
> IPQ5332 uses TSENS v2.3.3 with combined interrupt. RPM is not
> available in the SoC, hence adding new compatible to have the
> sensor enablement and calibration function.>
> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 8b7863c3989e..ee57713f6131 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -68,8 +68,10 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
> + items:

Drop items, you do not have multiple items.

> + - enum:
> + - qcom,ipq8074-tsens
> + - qcom,ipq5332-tsens

Keep the order.
>
> - description: v2 of TSENS with combined interrupt
> items:
> @@ -289,6 +291,7 @@ allOf:
> contains:
> enum:
> - qcom,ipq8074-tsens
> + - qcom,ipq5332-tsens

And here

> then:
> properties:
> interrupts:
> @@ -304,6 +307,7 @@ allOf:
> contains:
> enum:
> - qcom,ipq8074-tsens
> + - qcom,ipq5332-tsens

And here.

> - qcom,tsens-v0_1
> - qcom,tsens-v1
> - qcom,tsens-v2

Best regards,
Krzysztof