Re: [PATCH] rust: kernel: str: Implement Debug for CString

From: Martin Rodriguez Reboredo
Date: Fri Jul 14 2023 - 09:47:06 EST


On 7/14/23 09:21, Asahi Lina wrote:
On 14/07/2023 18.48, Alice Ryhl wrote:
Asahi Lina <lina@xxxxxxxxxxxxx> writes:
Trivial implementation.

Signed-off-by: Asahi Lina <lina@xxxxxxxxxxxxx>

The commit message is a bit short, but the change itself looks fine.

Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

It's so trivial I just didn't know what else to write... suggestions
welcome (for this or next time I have a patch like this) ^^

~~ Lina


Just describe what it does, like "cast the `CStr` to an `&str` and call
`fmt::Debug::fmt` with it". I'll add my Reviewed-by, so retain it in
case it's asked to change the commit message.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>