Re: [PATCH] clk: qcom: fix some Kconfig corner cases

From: Konrad Dybcio
Date: Tue Aug 01 2023 - 07:28:12 EST


On 1.08.2023 12:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The SM_GCC_8550 symbol and others can only be built for ARM64 or when
> compile testing, but it gets selected by other drivers that can also be
> built for 32-bit ARCH_QCOM when not compile testing, which results in
> a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for SM_GCC_8550
> Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n])
> Selected by [m]:
> - SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
> - SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
>
> Add further 'depends on' statements to tighten this in a way that
> avoids the missing dependencies.
>
> Fixes: fd0b5b106fcab ("clk: qcom: Introduce SM8350 VIDEOCC")
> Fixes: 441fe711be384 ("clk: qcom: videocc-sm8450: Add video clock controller driver for SM8450")
> Fixes: f53153a37969c ("clk: qcom: videocc-sm8550: Add video clock controller driver for SM8550")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad