Re: [PATCH] gpio: pmic-eic-sprd: remove unnecessary call to platform_set_drvdata()

[Bartosz Golaszewski]

On Fri, Jul 28, 2023 at 8:08 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-pmic-eic-sprd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index c3e4d90f6b18..bfb003ccbd99 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -363,7 +363,6 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
>                 return ret;
>         }
>
> -       platform_set_drvdata(pdev, pmic_eic);
>         return 0;
>  }
>
> --
> 2.34.1
>

Applied, thanks!

Bartosz