Re: [PATCH] gpio: rc5t583: remove unneeded call to platform_set_drvdata()

[Bartosz Golaszewski]

On Fri, Jul 28, 2023 at 8:20 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-rc5t583.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c
> index 4fae3ebea790..c34dcadaee36 100644
> --- a/drivers/gpio/gpio-rc5t583.c
> +++ b/drivers/gpio/gpio-rc5t583.c
> @@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
>         if (pdata && pdata->gpio_base)
>                 rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
>
> -       platform_set_drvdata(pdev, rc5t583_gpio);
> -
>         return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
>                                       rc5t583_gpio);
>  }
> --
> 2.34.1
>

Applied, thanks!

Bartosz