Re: [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings

[Doug Anderson]

Hi,

On Fri, Aug 4, 2023 at 2:58 AM Sheng-Liang Pan
<sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Introduce more sc7180-lazor sku and board version configuration,
> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> add new board version 10 for audio codec ALC5682i-VS.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>
> Changes in v2:
> - add new entry rev9 with Parade bridge chip
>
>  .../devicetree/bindings/arm/qcom.yaml         | 55 +++++++++++++++++++
>  1 file changed, 55 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..dce7b771a280 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -470,6 +470,11 @@ properties:
>            - const: google,lazor-rev8
>            - const: qcom,sc7180
>
> +      - description: Acer Chromebook Spin 513 Parade bridge chip (rev9)

You probably didn't need to include "Parade bridge chip" in the
description since that's implied by "rev9"


> @@ -512,11 +522,26 @@ properties:
>            - const: google,lazor-rev8-sku0
>            - const: qcom,sc7180
>
> +      - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9)
> +        items:
> +          - const: google,lazor-rev9-sku0
> +          - const: qcom,sc7180
> +
>        - description: Acer Chromebook Spin 513 with LTE (newest rev)
>          items:
>            - const: google,lazor-sku0
>            - const: qcom,sc7180
>
> +      - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9)
> +        items:
> +          - const: google,lazor-rev9-sku10
> +          - const: qcom,sc7180

The no-eSIM and normal LTE should be combined into one, just like they
are in your device tree. If you look at patch #3, you can see
"sc7180-trogdor-lazor-r9-lte.dts" contains:

compatible = "google,lazor-rev9-sku0", "google,lazor-rev9-sku10", "qcom,sc7180";

You need to have a single entry here that matches that. That means one
entry that has both rev9-sku0 and rev9-sku10.

You should be running "make dtbs_check" at the end of your series. As
Krzysztof would say, (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions)


-Doug