Re: [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings

From: Konrad Dybcio
Date: Mon Aug 07 2023 - 09:37:23 EST


On 4.08.2023 18:30, Doug Anderson wrote:
> Hi,
>
> On Fri, Aug 4, 2023 at 2:58 AM Sheng-Liang Pan
> <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> Introduce more sc7180-lazor sku and board version configuration,
>> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
>> add new board version 10 for audio codec ALC5682i-VS.
>>
>> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>> ---
[...]

>
> You should be running "make dtbs_check" at the end of your series. As
Ideally on each patch separately, with:

# or you can set git config alias.last describe --abbrev=0, thx Bjorn
git rebase -i $(git describe --abbrev=0)
replace 'pick' -> 'edit'
while (rebase is ongoing, can probably check retval of git rebase --continue)
do "make ... dtbs check something.."

as otherwise you may slip in a breakage inbetween that you fix later on

Konrad