Re: [PATCH v3] scripts: generate_rust_analyzer: provide `cfg`s for `core` and `alloc`

From: Miguel Ojeda
Date: Sat Aug 05 2023 - 06:46:36 EST


On Fri, Aug 4, 2023 at 7:14 PM Martin Rodriguez Reboredo
<yakoyoku@xxxxxxxxx> wrote:
>
> Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>

Thanks Martin!

I am a bit confused about the Suggested-by -- did you add it due to
the suggestion from v1 of passing variables via command-line
arguments? If so, I appreciate the gesture, but the main idea/report
(passing the missing `cfg`s for `core` and `alloc`) is yours! :)

The patch seems fine, I will test & apply it soon. If someone wants to
give it a Tested-by with rust-analyzer, that would be great too,
thanks! (note: it applies on top of `rust-next`).

Cheers,
Miguel