Re: [PATCH v3] scripts: generate_rust_analyzer: provide `cfg`s for `core` and `alloc`

[Martin Rodriguez Reboredo]

On 8/5/23 07:46, Miguel Ojeda wrote:
> On Fri, Aug 4, 2023 at 7:14 PM Martin Rodriguez Reboredo
> <yakoyoku@xxxxxxxxx> wrote:
> > Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
>
> Thanks Martin!
>
> I am a bit confused about the Suggested-by -- did you add it due to
> the suggestion from v1 of passing variables via command-line
> arguments? If so, I appreciate the gesture, but the main idea/report
> (passing the missing `cfg`s for `core` and `alloc`) is yours! :)

Ah, it was because you suggested the commit's text, should have been
more clear about it, I thought that the "Suggested-by" was for any
suggestions in reviews, and in reality it was for suggestions for
the kernel itself. In this case I've got confused. So, because I saw
the issue with the `rust-project.json` I'd like to rescind that
"Suggested-by", though, FWIW you still get credit in the end when you
do the sign-off at merge. 😇

> The patch seems fine, I will test & apply it soon. If someone wants to
> give it a Tested-by with rust-analyzer, that would be great too,
> thanks! (note: it applies on top of `rust-next`).
>
> Cheers,
> Miguel

If someone wants to test it, just try in your IDE to go into the
definition of some member of `core` and `alloc`, e.g. `Pin` or
`Vector`.