RE: [PATCH v1 RESEND] usb: dwc3: core: configure TX/RX threshold for DWC3_IP

From: Stanley Chang[昌育德]
Date: Mon Aug 07 2023 - 22:14:58 EST


Hi Thinh,

> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
> > f6689b731718..a0a54e5c4ad9 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1262,6 +1262,39 @@ static int dwc3_core_init(struct dwc3 *dwc)
> > }
> > }
> >
> > + if (DWC3_IP_IS(DWC3)) {
> > + u8 rx_thr_num = dwc->rx_thr_num_pkt_prd;
> > + u8 rx_maxburst = dwc->rx_max_burst_prd;
> > + u8 tx_thr_num = dwc->tx_thr_num_pkt_prd;
> > + u8 tx_maxburst = dwc->tx_max_burst_prd;
>
> These are meant for periodic settings. You're overloading them for
> non-periodic settings.
>
I will add new property for non-periodic settings.

Thanks,
Stanley